dgb: pin oracle SOFTFORKS_REQUIRED set (Phase-B conformance guard) - #273
Merged
Conversation
Test-only Phase-B pool/share conformance guard. Locks PoolConfig::
SOFTFORKS_REQUIRED to the oracle set in frstrtr/p2pool-dgb-scrypt
networks/digibyte.py:25 — {nversionbips,csv,segwit,reservealgo,odo,
taproot}. reservealgo and odo are DigiByte-unique; a silent add or
drop would mis-signal softfork requirements vs the oracle network.
Fenced to src/impl/dgb/test/share_test.cpp only; no shared-base,
CMake, or build.yml touch; dgb_share_test already allowlisted. No
consensus value changes (guards what already ships). 10/10 green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Test-only Phase-B pool/share conformance pin. Locks
dgb::PoolConfig::SOFTFORKS_REQUIREDto the oracle set in frstrtr/p2pool-dgb-scryptnetworks/digibyte.py:25:reservealgoandodoare DigiByte-unique (absent from BTC/LTC). A silent add or drop would make the embedded daemon mis-signal softfork requirements vs the oracle network — this guard makes any drift loud (exact-set EQ + explicit member + cardinality checks).Fence
src/impl/dgb/test/share_test.cpponly — no shared-base, CMake, or build.yml.dgb_share_testalready allowlisted.Verify
dgb_share_test10/10 green (newOracleSoftforksRequired+ 9 existing). GPG-signed bd4a150.Bucket
3-bucket rule: SOFTFORKS_REQUIRED is a bucket-2 v36-native shared param conformed per-coin against each coin oracle (not an isolation primitive).